Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
This PR aims to remove Trivy usage from the devcontainer/tooling and CI build pipeline.
Changes:
- Stubbed Trivy Make targets in
trivy.mkand the repoMakefile(replacing scans withecho "Not implemented"). - Commented out Trivy installation in the base devcontainer Dockerfile.
- Commented out parts of the GitHub Actions workflow related to Trivy setup and scan result handling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/base/.devcontainer/Mk/trivy.mk |
Replaces Trivy targets with stubs and comments out previous Trivy commands. |
src/base/.devcontainer/Dockerfile |
Comments out the Trivy build stage and binary copy into the image. |
Makefile |
Replaces image scan targets with stubs and comments out previous Trivy scan logic. |
.github/workflows/build_multi_arch_image.yml |
Comments out Trivy setup and some scan-result steps (but leaves a scan step active). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details