Fix: Open generics inheritance ignored based on registration order (AutoMapper #4567 backport)#8
Open
gthen95 wants to merge 1 commit intoNET-Sorcery:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports a fix from AutoMapper (#4567) to ensure open generic inheritance works consistently, regardless of the order in which the maps are registered.
The Issue:
When a derived concrete map (e.g.,
CreateMap<SourceDerived, DestinationDerived>()) is declared before its open generic base map, the inheritance configuration is ignored. It only works if declared in the reverse order. This happens because the configuration captures the initial instance of theTypeMapbefore the open generics are fully resolved.The Fix:
Updated
ProfileMap.csto resolve the inheritedTypeMapdirectly from theGlobalConfigurationrather than using the currently instancedTypeMapConfiguration. This guarantees that the fully materialized type map is used, making the registration order irrelevant.References: