Skip to content

added fortitude launcher script#211

Merged
Pierre-siddall merged 4 commits intoMetOffice:mainfrom
mo-lucy-gordon:add_fortitude_launcher_script
Mar 18, 2026
Merged

added fortitude launcher script#211
Pierre-siddall merged 4 commits intoMetOffice:mainfrom
mo-lucy-gordon:add_fortitude_launcher_script

Conversation

@mo-lucy-gordon
Copy link
Contributor

@mo-lucy-gordon mo-lucy-gordon commented Mar 12, 2026

PR Summary

Sci/Tech Reviewer: @james-bruten-mo
Code Reviewer: @Pierre-siddall

Adds a script to launch fortitude for the test suite, determines which configuration to use for testing each part of the code, and handles error messages and outputs.

Blocks, Linked: MetOffice/lfric_apps#150

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Tested with flake 8

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

@mo-lucy-gordon mo-lucy-gordon marked this pull request as draft March 12, 2026 12:32
@mo-lucy-gordon mo-lucy-gordon marked this pull request as ready for review March 12, 2026 14:25
Copy link
Collaborator

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to set the file as executable given how it's being called from LFRic
Run chmod +x fortitude_launcher.py and then commit and push the changes

@mo-lucy-gordon
Copy link
Contributor Author

I think you need to set the file as executable given how it's being called from LFRic Run chmod +x fortitude_launcher.py and then commit and push the changes

Yes sorry I forgot to do this again after my final edit, but it should work now.

Copy link
Collaborator

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, cheers

@github-actions github-actions bot requested a review from Pierre-siddall March 18, 2026 11:21
Copy link
Contributor

@Pierre-siddall Pierre-siddall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lucy, really good and well thought out script with clear attention to where text is output and error handling.

@Pierre-siddall Pierre-siddall merged commit 4387949 into MetOffice:main Mar 18, 2026
6 checks passed
@james-bruten-mo james-bruten-mo added this to the Summer 2026 milestone Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants