Skip to content

Extend _tensor_elementwise_impl with binary functions part 2#2804

Open
vlad-perevezentsev wants to merge 8 commits intomove_elementwise_binary_implfrom
move_elementwise_binary_impl_part_2
Open

Extend _tensor_elementwise_impl with binary functions part 2#2804
vlad-perevezentsev wants to merge 8 commits intomove_elementwise_binary_implfrom
move_elementwise_binary_impl_part_2

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Mar 5, 2026

This PR extends _tensor_elementwise_impl with part of binary functions :

divide,
equal,
floor_divide,
greater,
greater_equal,
hypot,
less,
less_equal,
logaddexp

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Mar 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

View rendered docs @ https://intelpython.github.io/dpnp/pull/2804/index.html

@vlad-perevezentsev vlad-perevezentsev marked this pull request as ready for review March 11, 2026 15:56
@vlad-perevezentsev vlad-perevezentsev force-pushed the move_elementwise_binary_impl_part_2 branch from a3b2d00 to 608802a Compare March 11, 2026 18:53
ndgrigorian
ndgrigorian previously approved these changes Mar 12, 2026
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over includes and nothing stood out, this one LGTM

@ndgrigorian ndgrigorian self-requested a review March 12, 2026 01:11
@ndgrigorian ndgrigorian dismissed their stale review March 12, 2026 01:11

was put in wrong PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants