Skip to content

test: add test for null field cases#367

Merged
NguyenHoangSon96 merged 4 commits intomainfrom
test/add-test-null-field
Mar 17, 2026
Merged

test: add test for null field cases#367
NguyenHoangSon96 merged 4 commits intomainfrom
test/add-test-null-field

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Mar 17, 2026

Closes #

Proposed Changes

  • Add test cases for query null fields.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 added this to the 1.8.0 milestone Mar 17, 2026
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Mar 17, 2026
@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.90%. Comparing base (fef892e) to head (ae53b03).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          20       20           
  Lines        1397     1397           
  Branches      241      241           
=======================================
  Hits         1228     1228           
  Misses         81       81           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96 NguyenHoangSon96 force-pushed the test/add-test-null-field branch from 67ebcad to 056d1cf Compare March 17, 2026 09:17
Copy link
Contributor

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add assertions that returned values are actually null.

@NguyenHoangSon96
Copy link
Contributor Author

Can you please also add assertions that returned values are actually null.

Hi, added the missing assertions.
Please check again

Copy link
Contributor

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NguyenHoangSon96 NguyenHoangSon96 merged commit 3d44fe6 into main Mar 17, 2026
17 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the test/add-test-null-field branch March 17, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants