pyln-testing: move mnemonic dependency directly into pyln-testing#8876
Open
daywalker90 wants to merge 1 commit intoElementsProject:masterfrom
Open
pyln-testing: move mnemonic dependency directly into pyln-testing#8876daywalker90 wants to merge 1 commit intoElementsProject:masterfrom
daywalker90 wants to merge 1 commit intoElementsProject:masterfrom
Conversation
daywalker90
force-pushed
the
pyln-testing-mnemonic-fix
branch
from
dbdd0f5 to
09c4f8d
Compare
sangbida
added
the
Status::Ready for Review
When installing only pyln-testing directly it is missing the mnemonic dependency. Changelog-None
daywalker90
force-pushed
the
pyln-testing-mnemonic-fix
branch
from
09c4f8d to
90b65d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing only pyln-testing, without the cln-meta package, it is missing the mnemonic dependency.
I noticed this in the currently broken nightly CI of the plugins repo and i'm pretty sure this will happen when pyln-testing is published to pypi aswell.
Since mnemonic is only used in pyln-testing it should be in it's pyproject.toml.