policy: allow exact annex padding for simplicity spends #1539
Draft
delta1 wants to merge 3 commits intoElementsProject:masterfrom
Draft
policy: allow exact annex padding for simplicity spends #1539delta1 wants to merge 3 commits intoElementsProject:masterfrom
delta1 wants to merge 3 commits intoElementsProject:masterfrom
Conversation
Contributor
|
I'll have some more comment later but first and foremost there is no need to amend the Simplicity C code. Instead there is a Have a careful read of the documentation for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements BlockstreamResearch/simplicity#290 for Elements standardness policy.
Looking for approach feedback.
90c380f should probably be upstreamed into simplicity itself?
Something concerning to be investigated is that
Cost::get_paddingin rust-simplicity is returning a padding 3 bytes bigger than this calculation.. presumably an error in that method?