fix(vmm): preserve orphan VM workdir on restart#594
Merged
Conversation
kvinwang
force-pushed
the
worktree-vmm-no-delete-workdir
branch
from
14dcc4e to
bf07048
Compare
Only delete the VM workdir during cleanup if the .removing marker file is present (set by user-initiated remove_vm). Orphaned supervisor processes discovered at startup without the marker now have their workdir preserved, preventing accidental data loss on VMM restart.
kvinwang
force-pushed
the
worktree-vmm-no-delete-workdir
branch
from
bf07048 to
6cdb79c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.removingmarker is present (user-initiatedremove_vm)Context
When VMM is killed and restarted, it discovers supervisor processes that don't match any loaded VM as "orphans" and calls
finish_remove_vmto clean them up. Previously this unconditionally deleted the workdir, destroying VM data (compose files, disk images, logs) that could be recovered.Test plan
remove_vmAPI — VM workdir should be deleted (.removingmarker present)remove_vmwith.removingmarker — cleanup resumes and deletes workdir