Fix install button selector for Falcon UI change#115
Merged
Conversation
The Foundry Python runtime is 3.13. Update pylint target to match so linting validates against the correct language features.
The Falcon App Catalog UI renamed the install button from 'Install app' to 'Save and install'. Update the selector to match, with .or() fallback for backwards compatibility.
javier-carrasco-crowdstrike
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Falcon App Catalog UI renamed the install button from "Install app" to "Save and install". This caused E2E test failures because
getByRole('button', { name: 'Install app' })no longer matches.Updated
clickInstallAppButton()inAppCatalogPage.tsto use'Save and install'as the primary selector with.or('Install app')fallback for backwards compatibility, matching the pattern already used in other foundry-sample repos.Verified locally - all 8 tests pass.