Open
Conversation
added 2 commits
March 13, 2026 17:31
Collaborator
|
Looks good. |
Collaborator
|
@lcaouen, Sonarqube is warning about method names. Can you please update to Java coding standard, i.e. method names to start with lower case? |
|
Contributor
Author
|
should be better now ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings displayed in the dialog box were not just the ones from the settings.ini but also all the parameters saved in memory after Pheobus start.
To avoid this problem, the solution is to chech the settings at the start instead of at the help dialobox opening.
Other advantage, the property files with the "reference" settings are only loaded once whereas it was done every time the dialog box was open.