Skip to content

Dct patch#1366

Open
garrettwrong wants to merge 2 commits intodevelopfrom
dct_patch
Open

Dct patch#1366
garrettwrong wants to merge 2 commits intodevelopfrom
dct_patch

Conversation

@garrettwrong
Copy link
Collaborator

Example code patch. Updates nworkers.

Default nworkers is cpu_count, and this patch implements -1, which from the docs is cpu_count-1.

https://docs.scipy.org/doc/scipy/reference/generated/scipy.fft.fft.html#scipy.fft.fft

@garrettwrong garrettwrong requested a review from j-c-c March 19, 2026 14:26
@garrettwrong garrettwrong self-assigned this Mar 19, 2026
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.84%. Comparing base (fd33079) to head (37e069d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1366   +/-   ##
========================================
  Coverage    90.84%   90.84%           
========================================
  Files          135      135           
  Lines        14658    14658           
========================================
  Hits         13316    13316           
  Misses        1342     1342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@garrettwrong garrettwrong marked this pull request as ready for review March 19, 2026 15:11
@garrettwrong garrettwrong requested a review from janden as a code owner March 19, 2026 15:11
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettwrong
Copy link
Collaborator Author

Thanks all. I'll rebase merge this little guy after the CL docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants