London | ITP-JAN26 | Ihor Taradaiko | Sprint 3 | Alarm Clock#1056
Open
ihortar wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London | ITP-JAN26 | Ihor Taradaiko | Sprint 3 | Alarm Clock#1056ihortar wants to merge 1 commit intoCodeYourFuture:mainfrom
ihortar wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
ihortar
added
📅 Sprint 3
hkavalikas
added
Reviewed
hkavalikas
suggested changes
Mar 22, 2026
There was a problem hiding this comment.
What will happen if we don't add a value and click on "set alarm", or we add a negative value?
There was a problem hiding this comment.
Also, if we click on the set alarm multiple times, we are stacking the timers together, how can we handle it so the timer fully resets?
|
Finally, let's try to add a few more details on the Changelist. The purpose of the changelist is to mention individual updates/additions/changes made for this PR, not so much to add a headline (like the title) of the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Alarm Clock app