Draft
Conversation
Contributor
jason-raitz
commented
Mar 18, 2026
jason-raitz
commented
- removed unused client.search()
- added client.write_search_results_to_file()
- added method to iterate through search xml results
- added some xml fixtures for a first and last result for a sample search as well as the expected output xml for said search.
- removed unused client.search() - added client.write_search_results_to_file() - added method to iterate through search xml results - added some xml fixtures for a first and last result for a sample search as well as the expected output xml for said search.
- commenting out for now to use as template for new tests
Member
|
Since the eventual goal was to migrate Willa to this as well, I don't think |
anarchivist
reviewed
Mar 20, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
generally looks good. what else is left other than the tests?
Comment on lines
+19
to
+24
| NS = "http://www.loc.gov/MARC21/slim" | ||
| E.register_namespace("", NS) | ||
|
|
||
| # remove namespace that ElementTree adds to records when passed | ||
| _NS_DECL: str = f' xmlns="{NS}"' | ||
|
|
Member
There was a problem hiding this comment.
why are we stripping the namespace? does it lead to redundancy if we don't?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.