ext/pgsql: Enable lo_tell64/lo_truncate64 by removing dead VE_PG_LO64 guards#21437
Closed
KentarouTakeda wants to merge 1 commit intophp:masterfrom
Closed
ext/pgsql: Enable lo_tell64/lo_truncate64 by removing dead VE_PG_LO64 guards#21437KentarouTakeda wants to merge 1 commit intophp:masterfrom
KentarouTakeda wants to merge 1 commit intophp:masterfrom
Conversation
devnexen
reviewed
Mar 14, 2026
|
|
||
| #ifdef VE_PG_LO64 | ||
| if (PQserverVersion((PGconn *)pgsql->conn) >= 90300) { | ||
| offset = lo_tell64((PGconn *)pgsql->conn, pgsql->lofd); |
Member
There was a problem hiding this comment.
I would definitely prefer to have this as only path so we can deal with small and large objects all alike. same for lo_truncate part
devnexen
reviewed
Mar 14, 2026
ext/pgsql/pgsql.c
Outdated
| offset = lo_tell((PGconn *)pgsql->conn, pgsql->lofd); | ||
| } | ||
| #else | ||
| offset = lo_tell((PGconn *)pgsql->conn, pgsql->lofd); |
Member
There was a problem hiding this comment.
what I m trying to say with the changes we lose the ability to deal with 2GB+ objects. the *64 variant can deal with small objects too.
… guards The guards reference undefined VE_PG_LO64, a misspelling of HAVE_PG_LO64 (removed in phpGH-14628), making the 64-bit code paths permanently dead. Remove the guards to unconditionally enable the 64-bit variants for PostgreSQL >= 9.3, consistent with pg_lo_seek(). Dropped from phpGH-21386 as not suitable for backport.
KentarouTakeda
changed the title
KentarouTakeda
force-pushed
the
pgsql-remove-dead-VE_PG_LO64-guards
branch
from
1340e30 to
f308aee
Compare
Contributor
Author
|
Thanks, you're right. Updated to use the |
devnexen
approved these changes
Mar 14, 2026
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guards reference undefined VE_PG_LO64, a misspelling of HAVE_PG_LO64 (removed in GH-14628), making the 64-bit code paths permanently dead. Remove the guards to unconditionally enable the 64-bit variants for PostgreSQL >= 9.3, consistent with pg_lo_seek().
Dropped from GH-21386 as not suitable for backport.