ext/json: Remove unnecessary smart_str_alloc() before smart_str_appendc()#21435
Closed
arshidkv12 wants to merge 1 commit intophp:masterfrom
Closed
ext/json: Remove unnecessary smart_str_alloc() before smart_str_appendc()#21435arshidkv12 wants to merge 1 commit intophp:masterfrom
arshidkv12 wants to merge 1 commit intophp:masterfrom
Conversation
devnexen
reviewed
Mar 14, 2026
| checkpoint = buf->s ? ZSTR_LEN(buf->s) : 0; | ||
|
|
||
| /* pre-allocate for string length plus 2 quotes */ | ||
| smart_str_alloc(buf, len+2, 0); |
Member
There was a problem hiding this comment.
this line might be more useful than you think (i.e. upfront little optim). edit: well the comment just above says so..
Member
There was a problem hiding this comment.
I would not recommend to merge it, but if bukka thinks it's good I won't argue :)
Member
|
No, this is needed to avoid continuous reallocations of the string buffer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.